Memoize tagset cursor's key #3676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otoolep
force-pushed
the
memomize_key
branch
3 times, most recently
from
c1bf16e to
9a67776
Compare
CPU profiling shows that computing the tagset-based key of each point is significant CPU cost. These keys actually don't change per cursor, so precompute once at mapper-open time, and then use those values as points are drained from the cursor. Before this change the cursor tag was getting computed on every point, which involved marshalling tags.
|
+1, great find! |
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CPU profiling shows that computing the tagset-based key of each point is significant CPU cost (
formMeasurementTagSetKey). These keys actually don't change per cursor, so precompute per tagset cursor, and then tack this value onto mapper outputs.Before this change the cursor tagset-based key was getting computed for every point emitted by that cursor, which involved marshalling tags ever time a point was emitted.
With this change in place, on my machine, a partner's test query execution time was reduced by 30-40%.